Mirage Source

Free ORPG making software.
It is currently Thu Jan 01, 2026 6:07 am

All times are UTC




Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Redundant...?
PostPosted: Tue Oct 14, 2008 7:23 am 
Offline
Persistant Poster
User avatar

Joined: Thu Jul 24, 2008 6:42 am
Posts: 703
Google Talk: [email protected]
Okay, so I was scrolling through the code in the server, and I found this:

Code:
Private Sub mnuKickPlayer_Click()
Dim Name As String

    Name = frmServer.lvwInfo.SelectedItem.SubItems(3)
    If Not Name = "Not Playing" Then
        Call AlertMsg(FindPlayer(Name), "You have been kicked by the server owner!")
        CloseSocket (FindPlayer(Name))
    End If
End Sub


However the specific code in question is:
Code:
Call AlertMsg(FindPlayer(Name), "You have been kicked by the server owner!")
        CloseSocket (FindPlayer(Name))


As you can see, it calls an Alert, but then it also calls a CloseSocket. However, AlertMsg, calls close socket, so wouldn't that be redundant? I'm sure even if it is redundant, it isn't doing much to slow down the game, or if at all. Just wondering.

_________________
Image
GIAKEN wrote:
Since I'm into men, not women

GIAKEN wrote:
I can't take these huge penises anymore! All that's left is shame! And blood


Top
 Profile  
 
 Post subject: Re: Redundant...?
PostPosted: Tue Oct 14, 2008 7:13 pm 
Offline
Persistant Poster
User avatar

Joined: Thu Jul 24, 2008 6:42 am
Posts: 703
Google Talk: [email protected]
Yeah, I was just wondering. I'm sorta surprised I spotted that, I feel so special now.

_________________
Image
GIAKEN wrote:
Since I'm into men, not women

GIAKEN wrote:
I can't take these huge penises anymore! All that's left is shame! And blood


Top
 Profile  
 
 Post subject: Re: Redundant...?
PostPosted: Tue Oct 14, 2008 11:12 pm 
Offline
Persistant Poster
User avatar

Joined: Thu Jul 24, 2008 6:42 am
Posts: 703
Google Talk: [email protected]
DFA wrote:
shouldnt be surprised :-)
mirage source is one of the shittiest source codes in the history of programming, thats why its so easy to update and improve, and it explains the massive changelog.


Yes, but I'm one of the shittiest programmers in the history of programming, that's why I fail so hard to fix stuff, and add new features.

_________________
Image
GIAKEN wrote:
Since I'm into men, not women

GIAKEN wrote:
I can't take these huge penises anymore! All that's left is shame! And blood


Top
 Profile  
 
 Post subject: Re: Redundant...?
PostPosted: Tue Oct 14, 2008 11:42 pm 
Offline
Persistant Poster
User avatar

Joined: Thu Mar 29, 2007 10:30 pm
Posts: 1510
Location: Virginia, USA
Google Talk: [email protected]
Nean wrote:
DFA wrote:
shouldnt be surprised :-)
mirage source is one of the shittiest source codes in the history of programming, thats why its so easy to update and improve, and it explains the massive changelog.


Yes, but I'm one of the shittiest programmers in the history of programming, that's why I fail so hard to fix stuff, and add new features.


Everybody is the shittiest programmer when they first start.

_________________
Nean wrote:
Yes harold. Give it to me.

Image
Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group