Mirage Source

I didn't get a chance to work on MS4 much because my baby has been sick.

I saw one tiny thing in modGameLogic. When you hit enter it checks every command even if you don't have the "/", so why not check for that first?

Sub HandleKeyPresses

Add:

Right before:


Add:

Right After

Thanks for the small fix I added it already

Nice, I just added this.

To add on to this,

Instead of using Mid(1, somthing

Use Left(something)

Using Mid here is obviously quite stupid, and I (without any sources to back it up) assume Left is way faster than Mid.

i think Dugor forgot about these...


and


you should place them right before


and add an access check

From: http://www.aivosto.com/vbtips/stringopt2.html



So using Left$ is faster than Mid$.

You are correct, I did forget about those.

You would have to move those out of the 'Checking for commands' section and have another If Then statement to check for those.

What about Normal Player commands.

_________________

Okay I was thinking of a little bit different way to do the commands. What i came up with is very similar to HandleData.
This method would make it easier for users to add commands without using left, mid and whatnot and counting letters.

HandleKeyPresses

Add


After


Add

This code will split the string when there is a space and sets to the Command array.

Add:

Now we add a select case statement that will do different things depending on the actual command.

The following is just a simple example:


The following will first check to make sure there's more than one string in our array so we don't error out, then it will send the second string in the array. The first string will always be the command.





Just a little something to tell someone they don't have a valid command.


Then right before the

for the


Add


Just an idea. Let's hear what everyone thinks.

Sure that should work better

I would create a Map that maps each command to a memory address, and call each command's unique function by address.

Then you get rid of mile long functions, and make debugging easier... kinda

_________________

Why not try my app, ColorEye, on your Android devlce?
Do you like social gaming? Fight it out in Battle Juice!

I am a professional software developer in Salt Lake City, UT.

Like Verrigans source ?

I may write up something for that ... who knows.

I'll do it =3

_________________

Why not try my app, ColorEye, on your Android devlce?
Do you like social gaming? Fight it out in Battle Juice!

I am a professional software developer in Salt Lake City, UT.

Len and LenB are also the same speed.

But I started working on the next version a bit. I'm going to finish off Anthony's work then finish this.

Actually, I think len() is a constant time slower than lenb()

I've tested this before, I don't remember

O(len()) = O(lenb()) + C

_________________

Why not try my app, ColorEye, on your Android devlce?
Do you like social gaming? Fight it out in Battle Juice!

I am a professional software developer in Salt Lake City, UT.

I was just taking my info from:

http://www.aivosto.com/vbtips/stringopt2.html

Len is implemented in 6 assembly instructions in the VB runtime. LenB is even shorter: it runs just 5 instructions

Hah I was right! Their preformance is not equal, but almost One more clock cycle to complete a Len instruction

Also, who knows how they tested that stuff? Is the time O(n) or is it O(n^2)? How do those functions vary with string length? That's important More important than the time to complete just one call, in many cases.

_________________

Why not try my app, ColorEye, on your Android devlce?
Do you like social gaming? Fight it out in Battle Juice!

I am a professional software developer in Salt Lake City, UT.

It said inside the stuff you quoted

_________________

Why not try my app, ColorEye, on your Android devlce?
Do you like social gaming? Fight it out in Battle Juice!

I am a professional software developer in Salt Lake City, UT.

Fixed.

Fixed.

_________________

...